LPS-127990 Rename frontend-taglib and frontend-js-react-web npm modules to move them to @liferay organization by izaera · Pull Request #813 · liferay-frontend/liferay-portal

izaera · 2021-02-18T15:52:22Z

This is a rename of frontend-js-react-web and frontend-taglib which are the two critical packages.

Obsolete now: ~~This PR needs liferay/liferay-frontend-projects#408 to be merged and released to work. I'm sending it only for review purposes (for now).~~

izaera · 2021-02-18T15:53:16Z

ci:stop

jbalsas · 2021-02-18T15:55:31Z

I thought you were joking when you said

This is a rename of frontend-js-react-web and frontend-taglib which are the two critical packages.

But it is indeed JUST those 2 modules! 😱

izaera · 2021-02-18T15:56:22Z

Yes. When I started I thought we only needed to change things in package.json and npmscripts.config.js files 😅

izaera · 2021-02-18T15:57:40Z

I'm not sure how we are gonna merge all the changes without conflicts 😬 .

wincent

I'm not sure how we are gonna merge all the changes without conflicts 😬 .

I was going to say, "It probably won't be as bad as you think. The changes are pretty well localized and we can give Brian a heads-up that this is on the way so that he can merge it quickly when he sees it." But then I realized that you haven't run SF yet, which is going to reorder a lot of those import statements and increase the number of touched lines by quite a bit.

If you're baby-sitting this for days before actually sending it then you are probably going to experience some pain rebasing in the meantime, even if you have done git config --global rerere.enabled.true. I hope you are able to doing this in a mostly automated find-and-replace kind of way that can be easily re-run.

As I was reading this, it occurred to me that these unpublished packages are going to look even more like published packages than they did before because of all those more legit-looking import statements, even though they're not published. But better that it's consistent (and probably necessary too).

jbalsas · 2021-02-19T11:53:56Z

@izaera, we might want to rename the PR since this is not really "renaming all unpublished npm modules" after all, is it? 😂

izaera · 2021-02-19T12:02:01Z

And the LPS too.

izaera · 2021-02-19T13:10:48Z

npm-scripts 37.1.0 is broken

I need to release more versions and push more commits

jbalsas · 2021-02-19T13:15:56Z

I need to release more versions and push more commits

jbalsas · 2021-02-19T14:26:34Z

izaera · 2021-02-22T07:38:21Z

ci:test:sf

izaera · 2021-02-22T07:38:28Z

ci:test:relevant

calvinctvo · 2021-02-23T22:06:48Z

ci:test:relevant

liferay-continuous-integration · 2021-02-24T03:15:44Z

✔️ ci:test:stable - 9 out of 9 jobs passed

❌ ci:test:relevant - 21 out of 33 jobs passed in 3 hours 45 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: bf41ac8d3aa2dbf64656fa7c0635882079d28f09

Upstream Comparison:

Branch GIT ID: bf41ac8d3aa2dbf64656fa7c0635882079d28f09
Jenkins Build URL: Acceptance Upstream DXP (master) #1575

ci:test:stable - 9 out of 9 jobs PASSED

9 Successful Jobs:

ci:test:relevant - 21 out of 33 jobs PASSED

12 Failed Jobs:

21 Successful Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/9

Job Results:

22 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=18,label_exp=!master #377937

     [exec] * What went wrong:
     [exec] Execution failed for task ':runPoshi'.
     [exec] > There were failing tests. See the report at: file:///opt/dev/projects/github/liferay-portal/portal-web/tests/index.html
     [exec] 
     [exec] * Try:
     [exec] Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.
     [exec] 
     [exec] * Get more help at https://help.gradle.org
     [exec] 
     [exec] BUILD FAILED in 44m 8s
     [exec] Result: 1
     [copy] Copying 1 file to /opt/dev/projects/github/liferay-portal/test-portal-acceptance-pullrequest-batch(master)/AXIS_VARIABLE=18_label_exp=!master/builds/377937
     [copy] Copying 13 files to /opt/dev/projects/github/liferay-portal/test-portal-acceptance-pullrequest-batch(master)/AXIS_VARIABLE=18_label_exp=!master/builds/377937/screenshots
   [delete] Deleting: /opt/dev/projects/github/liferay-portal/null110375115.properties
clean-up-mobile-device:

[delete] Deleting: /opt/dev/projects/github/liferay-portal/null110375115.properties
clean-up-selenium-driver:

[exec] chromedriver: no process found

[exec] Result: 1

[delete] Deleting: /opt/dev/projects/github/liferay-portal/null110375115.properties
print-elasticsearch-indices:

[echo]

[echo] ##

[echo] ## Elasticsearch Liferay Company Index on Port 9201

[echo] ##

[echo]

[echo] {

[echo]   "took" : 2,

[echo]   "timed_out" : false,

[echo]   "_shards" : {

[echo]     "total" : 1,

[echo]     "successful" : 1,

[echo]     "skipped" : 0,

[echo]     "failed" : 0

[echo]   },

[echo]   "hits" : {

[echo]     "total" : {

[echo]       "value" : 25,

[echo]       "relation" : "eq"

[echo]     },

[echo]     "max_score" : 0.1162598,

[echo]     "hits" : [

[echo]       {

[echo]         "_index" : "liferay-20100",

[echo]         "_type" : "LiferayDocumentType",

[echo]         "_id" : "com.liferay.dynamic.data.mapping.model.DDMStructureLayout_PORTLET_42285",

[echo]         "_score" : 0.1162598,

[echo]         "_source" : {

[echo]           "entryClassPK" : "42285",

[echo]           "entryClassName" : "com.liferay.dynamic.data.mapping.model.DDMStructureLayout",

[echo]           "groupId" : "40978",

[echo]           "createDate_sortable" : 1614128144637,

[echo]           "userName" : "test test",

test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/1

Job Results:

739 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=0,label_exp=!master #329639

JournalArticleAnalyticsReportsInfoItemTest.testGetPublishDateWithDisplayPage

java.lang.AssertionError: expected: java.util.Date<Wed Feb 24 01:45:26 GMT 2021> but was: java.util.Date<Wed Feb 24 01:45:26 GMT 2021>

at org.junit.Assert.fail(Assert.java:89)

at org.junit.Assert.failNotEquals(Assert.java:835)

at org.junit.Assert.assertEquals(Assert.java:120)

at org.junit.Assert.assertEquals(Assert.java:146)

at com.liferay.analytics.reports.journal.internal.info.item.test.JournalArticleAnalyticsReportsInfoItemTest.testGetPublishDateWithDisplayPage(JournalArticleAnalyticsReportsInfoItemTest.java:193)

at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)

at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)

at java.lang.reflect.Method.invoke(Method.java:498)

at com.liferay.arquillian.extension.junit.bridge.server.TestExecutorRunnable$3.evaluate(TestExecutorRunnable.java:353)

at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)

at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:99)

at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:99)

at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:99)

at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:99)

at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:99)

at com.l...

Failures in common with acceptance upstream results at bf41ac8:

test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0
Job Results:
20 Tests Passed.
0 Tests Failed.
1. AXIS_VARIABLE=6,label_exp=!master #466032
  Build was aborted
test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/9
Job Results:
22 Tests Passed.
1 Test Failed.
1. AXIS_VARIABLE=17,label_exp=!master #377937

test-portal-acceptance-pullrequest-batch(master)/modules-semantic-versioning-jdk8/0

Job Results:

0 Tests Passed.
2 Tests Failed.

AXIS_VARIABLE=1,label_exp=!master #218396

Please fix semantic versioning on izaera/fix-sec-2

     [exec]

[exec] > Task :apps:journal:journal-item-selector-web:compileJSP

[exec] Note: /opt/dev/projects/github/liferay-portal/modules/apps/journal/journal-item-selector-web/build/jspc/org/apache/jsp/journal_005fimages_jsp.java uses unchecked or unsafe operations.

[exec] Note: Recompile with -Xlint:unchecked for details.

[exec]

[exec] > Task :apps:journal:journal-item-selector-web:jar

[exec] > Task :apps:journal:journal-item-selector-web:autoUpdateXml SKIPPED

[exec] > Task :apps:journal:journal-item-selector-web:baseline SKIPPED

[exec] > Task :apps:journal:journal-item-selector-web:syncVersions

[exec]

[exec] > Task :apps:journal:journal-content-web:generateJSPJava

[exec] Compiling JSP files of project ':apps:journal:journal-content-web' with /opt/dev/projects/github/liferay-portal/bundles/tomcat-9.0.40/webapps/ROOT/WEB-INF/lib/util-taglib.jar as dependency in place of 'com.liferay.portal:com.liferay.util.taglib'

[exec]

[exec] > Task :apps:journal:journal-content-web:compileJSP

[exec] Note: Some input files use or override a deprecated API.

[exec] Note: Recompile with -Xlint:deprecation for details.

[exec]

[exec] > Task :apps:journal:journal-content-web:jar

[exec] > Task :apps:journal:journal-content-web:autoUpdateXml SKIPPED

[exec] > Task :apps:journal:journal-content-web:baseline SKIPPED

[exec] > Task :apps:journal:journal-content-web:syncVersions

[exec] Gradle build finished at 2021-02-24 01:15:46.934.

[exec]

[exec]

[exec] FAILURE: Build completed with 2 failures.

[exec]

[exec] 1: Task failed with an exception.

[exec] -----------

[exec] * What went wrong:

[exec] Execution failed for task ':apps:frontend-taglib:frontend-taglib-react:baseline'.

[exec] > A failure occurred while executing com.liferay.gradle.plugins.baseline.internal.work.BaselineWorkAction

[exec]    > org.gradle.api.GradleException: Semantic versioning is incorrect while checking /opt/dev/projects/github/liferay-portal/tools/sdk/dist/com.liferay.frontend.taglib.react-5.0.0.jar against /opt/dev/projects/github/liferay-portal/.gradle/caches/modules-2/files-2.1/com.liferay/com.liferay.frontend.taglib.react/4.1.2/ec050fd1c3aa0f51ab209177255ba6f126eabeef/com.liferay.frontend.taglib.react-4.1.2.jar

AXIS_VARIABLE=0,label_exp=!master #218396

Please fix semantic versioning on izaera/fix-sec-2

     [exec]   PACKAGE_NAME                                       DELTA      CUR_VER    BASE_VER   REC_VER    WARNINGS

[exec] = ================================================== ========== ========== ========== ========== ==========

[exec] * com.liferay.data.engine.renderer                   MINOR      1.2.0      1.2.0      1.3.0      VERSION INCREASE REQUIRED

[exec] 	<   class      com.liferay.data.engine.renderer.DataLayoutRendererContext

[exec] 		+   method     getDefaultLanguageId()

[exec] 			+   return     java.lang.String

[exec] 		+   method     setDefaultLanguageId(java.lang.String)

[exec] 			+   return     void

[exec] [Baseline Report] Mode: diff (persisted)

[exec] Semantic versioning is incorrect while checking /opt/dev/projects/github/liferay-portal/tools/sdk/dist/com.liferay.data.engine.api-4.0.0.jar against /opt/dev/projects/github/liferay-portal/.gradle/caches/modules-2/files-2.1/com.liferay/com.liferay.data.engine.api/3.5.4/d054d179461a8661cbb9d98d7836ccd80a6c635d/com.liferay.data.engine.api-3.5.4.jar

...

liferay-continuous-integration · 2021-02-24T07:14:37Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#7936
Jenkins Report:jenkins-report.html
Jenkins Suite: relevant
Pull Request:liferay-frontend#813
Spira Release:/Liferay DXP 7.4/Pull Request/ci:test:relevant
Spira Release Build:master - izaera > liferay-frontend - PR#813 - 2021-02-23[15:23:44]
Spira Jenkins Build:publish-spira-report#16426

izaera · 2021-02-24T08:04:22Z

CI is going crazy 🤦 :

java.lang.AssertionError: 
    expected: java.util.Date<Wed Feb 24 01:45:26 GMT 2021> 
    but was:  java.util.Date<Wed Feb 24 01:45:26 GMT 2021>

izaera · 2021-02-24T08:05:43Z

Going to rebase, because I'm sure I'll have to change more files and run CI again.

izaera · 2021-02-24T09:22:00Z

ci:test:sf

izaera · 2021-02-24T09:22:05Z

ci:test:relevant

liferay-continuous-integration · 2021-02-24T09:28:50Z

✔️ ci:test:sf - 1 out of 1 jobs passed in 6 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: bf41ac8d3aa2dbf64656fa7c0635882079d28f09

Sender Branch:

Branch Name: fix-sec-2
Branch GIT ID: 888b5a18f7549256fafb2480cff50d503e870467

1 out of 1jobs PASSED

1 Successful Jobs:

test-portal-source-format

For more details click here.

liferay-continuous-integration · 2021-02-24T10:44:24Z

Jenkins Build:test-portal-source-format#5285
Jenkins Report:jenkins-report.html
Jenkins Suite: sf
Pull Request:liferay-frontend#813
Spira Release:/Liferay DXP 7.4/Pull Request/ci:test:sf
Spira Release Build:master - izaera > liferay-frontend - PR#813 - 2021-02-24[01:23:19]
Spira Jenkins Build:publish-spira-report#13545

liferay-continuous-integration · 2021-02-24T17:52:34Z

✔️ ci:test:stable - 9 out of 9 jobs passed

❌ ci:test:relevant - 21 out of 33 jobs passed in 7 hours 6 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: bf41ac8d3aa2dbf64656fa7c0635882079d28f09

Upstream Comparison:

Branch GIT ID: bf41ac8d3aa2dbf64656fa7c0635882079d28f09
Jenkins Build URL: Acceptance Upstream DXP (master) #1575

ci:test:stable - 9 out of 9 jobs PASSED

9 Successful Jobs:

ci:test:relevant - 21 out of 33 jobs PASSED

12 Failed Jobs:

21 Successful Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8/0

Job Results:

9053 Tests Passed.
1 Test Failed.

AXIS_VARIABLE=23,label_exp=!master #405528

SearchRequestBuilderTest.testAddRescore

org.junit.ComparisonFailure: {"from":0,"size":10000,"query":{"bool":{"must":[{"bool":{"must":[{"bool":{"should":[{"bool":{"must":[{"match":{"comments":{"query":"delta"}}}],"should":[{"match_phrase":{"comments":{"query":"delta","slop":50}}},{"match_phrase":{"comments":{"query":"delta","boost":2.0}}}]}},{"bool":{"must":[{"match":{"content":{"query":"delta"}}}],"should":[{"match_phrase":{"content":{"query":"delta","slop":50}}},{"match_phrase":{"content":{"query":"delta","boost":2.0}}}]}},{"bool":{"must":[{"match":{"description":{"query":"delta"}}}],"should":[{"match_phrase":{"description":{"query":"delta","slop":50}}},{"match_phrase":{"description":{"query":"delta","boost":2.0}}}]}},{"bool":{"should":[{"wildcard":{"properties":{"wildcard":"*delta*"}}}]}},{"bool":{"must":[{"bool":{"should":[{"match":{"title":{"query":"delta"}}},{"match_phrase_prefix":{"title":{"query":"delta"}}}]}}],"should":[{"match_phrase":{"title":{"query":"delta","boost":2.0}}}]}},{"bool":{"should":[{"match_phrase":{"url":{"query":"delta"}}},{"bool":{"should":[{"wildcard":{"url":{"wildcard":"*delta*"}}}]}},{"match_phrase_prefix":{"url":{"query":"delta","max_expansions":300}}}]}},{"bool":{"should":[{"wildcard":{"userName":{"wildcard":"*delta*"}}}]}},{"bool":{"must":[{"match":{"assetCategoryTitles_en_US":{"query":"delta"}}}],"should":[{"match_phrase":{"assetCategoryTitles_en_US":{"query":"delta","slop":50}}},{"match_phrase":{"assetCategoryTitles_en_US":{"query":"delta","boost":2.0}}}]}},{"bool":{"must":[{"bo...

Failures in common with acceptance upstream results at bf41ac8:

test-portal-acceptance-pullrequest-batch(master)/modules-semantic-versioning-jdk8/0

Job Results:

0 Tests Passed.
2 Tests Failed.

AXIS_VARIABLE=1,label_exp=!master #320309

Please fix semantic versioning on izaera/fix-sec-2

     [exec] 
     [exec] > Task :apps:journal:journal-item-selector-web:compileJSP
     [exec] Note: /opt/dev/projects/github/liferay-portal/modules/apps/journal/journal-item-selector-web/build/jspc/org/apache/jsp/journal_005fimages_jsp.java uses unchecked or unsafe operations.
     [exec] Note: Recompile with -Xlint:unchecked for details.
     [exec] 
     [exec] > Task :apps:journal:journal-item-selector-web:jar
     [exec] > Task :apps:journal:journal-item-selector-web:autoUpdateXml SKIPPED
     [exec] > Task :apps:journal:journal-item-selector-web:baseline SKIPPED
     [exec] > Task :apps:journal:journal-item-selector-web:syncVersions
     [exec] 
     [exec] > Task :apps:journal:journal-content-web:generateJSPJava
     [exec] Compiling JSP files of project ':apps:journal:journal-content-web' with /opt/dev/projects/github/liferay-portal/bundles/tomcat-9.0.40/webapps/ROOT/WEB-INF/lib/util-taglib.jar as dependency in place of 'com.liferay.portal:com.liferay.util.taglib'
     [exec] 
     [exec] > Task :apps:journal:journal-content-web:compileJSP
     [exec] Note: Some input files use or override a deprecated API.
     [exec] Note: Recompile with -Xlint:deprecation for details.
     [exec] 
     [exec] > Task :apps:journal:journal-content-web:jar
     [exec] > Task :apps:journal:journal-content-web:autoUpdateXml SKIPPED
     [exec] > Task :apps:journal:journal-content-web:baseline SKIPPED
     [exec] > Task :apps:journal:journal-content-web:syncVersions
     [exec] Gradle build finished at 2021-02-24 12:58:50.003.
     [exec] 680 actionable tasks: 667 executed, 13 up-to-date
     [exec] 
     [exec] 
     [exec] FAILURE: Build completed with 2 failures.
     [exec] 
     [exec] 1: Task failed with an exception.
     [exec] -----------
     [exec] * What went wrong:
     [exec] Execution failed for task ':apps:frontend-taglib:frontend-taglib-react:baseline'.
     [exec] > A failure occurred while executing com.liferay.gradle.plugins.baseline.internal.work.BaselineWorkAction
     [exec]    > org.gradle.api.GradleException: Semantic versioning is incorrect while checking /opt/dev/projects/github/liferay-portal/tools/sdk/dist/com.liferay.frontend.taglib.react-5.0.0.jar against /opt/dev/projects/github/liferay-portal/.gradle/caches/modules-2/files-2.1/com.liferay/com.liferay.frontend.taglib.react/4.1.2/ec050fd1c3aa0f51ab209177255ba6f126eabeef/com.liferay.frontend.taglib.react-4.1.2.jar

AXIS_VARIABLE=0,label_exp=!master #320309

Please fix semantic versioning on izaera/fix-sec-2

     [exec]   PACKAGE_NAME                                       DELTA      CUR_VER    BASE_VER   REC_VER    WARNINGS  
     [exec] = ================================================== ========== ========== ========== ========== ==========
     [exec] * com.liferay.data.engine.renderer                   MINOR      1.2.0      1.2.0      1.3.0      VERSION INCREASE REQUIRED
     [exec] 	<   class      com.liferay.data.engine.renderer.DataLayoutRendererContext
     [exec] 		+   method     getDefaultLanguageId()
     [exec] 			+   return     java.lang.String
     [exec] 		+   method     setDefaultLanguageId(java.lang.String)
     [exec] 			+   return     void
     [exec] [Baseline Report] Mode: diff (persisted)
     [exec] Semantic versioning is incorrect while checking /opt/dev/projects/github/liferay-portal/tools/sdk/dist/com.liferay.data.engine.api-4.0.0.jar against /opt/dev/projects/github/liferay-portal/.gradle/caches/modules-2/files-2.1/com.liferay/com.liferay.data.engine.api/3.5.4/d054d179461a8661cbb9d98d7836ccd80a6c635d/com.liferay.data.engine.api-3.5.4.jar

test-portal-acceptance-pullrequest-batch(master)/modules-unit-jdk8/0

Job Results:

1 Test Passed.
2 Tests Failed.

AXIS_VARIABLE=1,label_exp=!master #489050

	at hudson.remoting.Channel.close(Channel.java:1452)
	at hudson.remoting.Channel.close(Channel.java:1405)
	at hudson.slaves.SlaveComputer.closeChannel(SlaveComputer.java:832)
	at hudson.slaves.SlaveComputer.access$800(SlaveComputer.java:105)
	at hudson.slaves.SlaveComputer$3.run(SlaveComputer.java:741)
	at jenkins.util.ContextResettingExecutorService$1.run(ContextResettingExecutorService.java:28)
	at jenkins.security.ImpersonatingExecutorService$1.run(ImpersonatingExecutorService.java:59)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
	at java.lang.Thread.run(Thread.java:745)
ERROR: Step ???Publish JUnit test result report??? failed: no workspace for test-portal-acceptance-pullrequest-batch(master)/AXIS_VARIABLE=1,label_exp=!master #489050
ERROR: Step ???Cucumber reports??? failed: no workspace for test-portal-acceptance-pullrequest-batch(master)/AXIS_VARIABLE=1,label_exp=!master #489050
ERROR: Build step failed with exception
java.lang.NullPointerException
	at org.jenkinsci.plugins.postbuildscript.processor.Processor.<init>(Processor.java:51)
	at org.jenkinsci.plugins.postbuildscript.processor.ProcessorFactory.createDefaultProcessor(ProcessorFactory.java:24)
	at org.jenkinsci.plugins.postbuildscript.processor.ProcessorFactory.createMatrixProcessor(ProcessorFactory.java:35)
	at org.jenkinsci.plugins.postbuildscript.PostBuildScript.createProcessor(PostBuildScript.java:213)
	at org.jenkinsci.plugins.postbuildscript.PostBuildScript.perform(PostBuildScript.java:128)
	at hudson.tasks.BuildStepMonitor$1.perform(BuildStepMonitor.java:20)
	at hudson.model.AbstractBuild$AbstractBuildExecution.perform(AbstractBuild.java:744)
	at hudson.model.AbstractBuild$AbstractBuildExecution.performAllBuildSteps(AbstractBuild.java:690)
	at hudson.model.Build$BuildExecution.post2(Build.java:186)
	at hudson.model.AbstractBuild$AbstractBuildExecution.post(AbstractBuild.java:635)
	at hudson.model.Run.execute(Run.java:1841)
	at hudson.matrix.MatrixRun.run(MatrixRun.java:153)
	at hudson.model.ResourceController.execute(ResourceController.java:97)
	at hudson.model.Executor.run(Executor.java:429)
Build step 'Execute Scripts' marked build as failure
Finished: FAILURE

AXIS_VARIABLE=2,label_exp=!master #489050

	at hudson.remoting.Channel.close(Channel.java:1452)
	at hudson.remoting.Channel.close(Channel.java:1405)
	at hudson.slaves.SlaveComputer.closeChannel(SlaveComputer.java:832)
	at hudson.slaves.SlaveComputer.access$800(SlaveComputer.java:105)
	at hudson.slaves.SlaveComputer$3.run(SlaveComputer.java:741)
	at jenkins.util.ContextResettingExecutorService$1.run(ContextResettingExecutorService.java:28)
	at jenkins.security.ImpersonatingExecutorService$1.run(ImpersonatingExecutorService.java:59)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
	at java.lang.Thread.run(Thread.java:745)
ERROR: Step ???Publish JUnit test result report??? failed: no workspace for test-portal-acceptance-pullrequest-batch(master)/AXIS_VARIABLE=2,label_exp=!master #489050
ERROR: Step ???Cucumber reports??? failed: no workspace for test-portal-acceptance-pullrequest-batch(master)/AXIS_VARIABLE=2,label_exp=!master #489050
ERROR: Build step failed with exception
java.lang.NullPointerException
	at org.jenkinsci.plugins.postbuildscript.processor.Processor.<init>(Processor.java:51)
	at org.jenkinsci.plugins.postbuildscript.processor.ProcessorFactory.createDefaultProcessor(ProcessorFactory.java:24)
	at org.jenkinsci.plugins.postbuildscript.processor.ProcessorFactory.createMatrixProcessor(ProcessorFactory.java:35)
	at org.jenkinsci.plugins.postbuildscript.PostBuildScript.createProcessor(PostBuildScript.java:213)
	at org.jenkinsci.plugins.postbuildscript.PostBuildScript.perform(PostBuildScript.java:128)
	at hudson.tasks.BuildStepMonitor$1.perform(BuildStepMonitor.java:20)
	at hudson.model.AbstractBuild$AbstractBuildExecution.perform(AbstractBuild.java:744)
	at hudson.model.AbstractBuild$AbstractBuildExecution.performAllBuildSteps(AbstractBuild.java:690)
	at hudson.model.Build$BuildExecution.post2(Build.java:186)
	at hudson.model.AbstractBuild$AbstractBuildExecution.post(AbstractBuild.java:635)
	at hudson.model.Run.execute(Run.java:1841)
	at hudson.matrix.MatrixRun.run(MatrixRun.java:153)
	at hudson.model.ResourceController.execute(ResourceController.java:97)
	at hudson.model.Executor.run(Executor.java:429)
Build step 'Execute Scripts' marked build as failure
Finished: FAILURE

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/2
Job Results:
52 Tests Passed.
1 Test Failed.
1. AXIS_VARIABLE=14,label_exp=!master #489051
  1. LocalFile.SitesExportImportWithStaging#ImportLiveSiteToStagingSite - Poshi Report - Poshi Summary - Console Output
test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/3
Job Results:
60 Tests Passed.
1 Test Failed.
1. AXIS_VARIABLE=12,label_exp=!master #1977
  1. LocalFile.Publications#PublishParallelPublications - Poshi Report - Poshi Summary - Console Output
...

calvinctvo · 2021-02-24T18:41:42Z

Hi @izaera , I think it's safe to say that there's no unique failure for this PR. Every time ci:test:relevant runs, there's a different ci failures pops up. So I would say there's no blocker for this PR and you can manually forward.

liferay-continuous-integration · 2021-02-24T19:29:22Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#6766
Jenkins Report:jenkins-report.html
Jenkins Suite: relevant
Pull Request:liferay-frontend#813
Spira Release:/Liferay DXP 7.4/Pull Request/ci:test:relevant
Spira Release Build:master - izaera > liferay-frontend - PR#813 - 2021-02-24[02:37:53]
Spira Jenkins Build:publish-spira-report#16338

Note this needs liferay/liferay-frontend-projects#408 to be merged to work.

…-web

wincent · 2021-02-25T09:42:16Z

ci:test:sf

liferay-continuous-integration · 2021-02-25T09:49:06Z

✔️ ci:test:sf - 1 out of 1 jobs passed in 6 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 232b7029dbcc5cc632db42fdd9f88161634e3e96

Sender Branch:

Branch Name: fix-sec-2
Branch GIT ID: 53638f739d079c9b9856134d39eb1ec4ff6f4f3c

1 out of 1jobs PASSED

1 Successful Jobs:

test-portal-source-format

For more details click here.

wincent

SF is green, so I'd say we can manually forward this based on:

I think it's safe to say that there's no unique failure for this PR. Every time ci:test:relevant runs, there's a different ci failures pops up. So I would say there's no blocker for this PR and you can manually forward.

link

and:

test passes in the currently running CI run:
https://testray.liferay.com/reports/production/logs/test-1-7/1614163073964/test-portal[…]modules-integration-mysql57-jdk8/1/0/jenkins-console.txt.gz

search for testGetPublishDateWithDisplayPage

I'd chalk this up as a fluke/flaky

link

liferay-continuous-integration · 2021-02-25T10:07:03Z

Jenkins Build:test-portal-source-format#4738
Jenkins Report:jenkins-report.html
Jenkins Suite: sf
Pull Request:liferay-frontend#813
Spira Release:/Liferay DXP 7.4/Pull Request/ci:test:sf
Spira Release Build:master - izaera > liferay-frontend - PR#813 - 2021-02-25[01:42:37]
Spira Jenkins Build:publish-spira-report#16388

izaera · 2021-02-25T10:20:24Z

Sent manually as brianchandotcom#99212

izaera mentioned this pull request Feb 18, 2021

feat: support scoped npm packages liferay/liferay-frontend-projects#408

Merged

liferay-continuous-integration added ci:test:sf - pending ci:test:relevant - pending ci:test:stable - pending labels Feb 18, 2021

liferay-continuous-integration added ci:test:sf - failure and removed ci:test:sf - pending labels Feb 18, 2021

Repository owner deleted a comment from liferay-continuous-integration Feb 18, 2021

liferay-continuous-integration added ci:test:relevant - failure and removed ci:test:relevant - pending labels Feb 18, 2021

Repository owner deleted a comment from liferay-continuous-integration Feb 18, 2021

wincent reviewed Feb 19, 2021

View reviewed changes

Comment thread ...d-js/frontend-js-module-launcher/src/main/resources/META-INF/resources/webpack_federation.js

izaera changed the title ~~LPS-127990 Rename all unpublished npm modules to move them to @liferay organization~~ LPS-127990 Rename frontend-taglib and frontend-js-react-web npm modules to move them to @liferay organization Feb 19, 2021

izaera force-pushed the fix-sec-2 branch from e21b211 to bcfe255 Compare February 19, 2021 14:24

liferay-continuous-integration added ci:test:sf - pending ci:test:relevant - pending and removed ci:test:sf - failure ci:test:relevant - failure ci:test:stable - pending labels Feb 22, 2021

izaera added 9 commits February 25, 2021 09:46

LPS-127990 Scope all occurrences of frontend-js-react-web npm package

ad8ddd0

LPS-127990 Support namespaced npm packages in webpack federation

4945aa8

Note this needs liferay/liferay-frontend-projects#408 to be merged to work.

LPS-127990 Use npm-scripts 37.1.1

81c10d7

LPS-127990 SF

2b2ee86

LPS-127990 Upgrade npm-scripts to fix CI tests

2db6545

LPS-127990 Change two more missing refs to @liferay/frontend-js-react…

cb8deb8

…-web

LPS-123585 Remove bundler 3 from frontend-js-recharts

9e025bc

LPS-127990 SF

4653a1a

LPS-127990 Changed more references after rebase

53638f7

wincent reviewed Feb 25, 2021

View reviewed changes

Comment thread modules/apps/frontend-js/frontend-js-recharts/npmscripts.config.js

wincent reviewed Feb 25, 2021

View reviewed changes

Comment thread modules/package.json

wincent approved these changes Feb 25, 2021

View reviewed changes

izaera mentioned this pull request Feb 25, 2021

LPS-127990 Rename frontend-taglib and frontend-js-react-web npm modules to move them to @liferay organization brianchandotcom/liferay-portal#99212

Closed

john-co mentioned this pull request Feb 25, 2021

LPS-121903 Migrate v2 usages in roles/roles-admin-web #835

Closed

Conversation

izaera commented Feb 18, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

izaera commented Feb 18, 2021

Uh oh!

jbalsas commented Feb 18, 2021

Uh oh!

izaera commented Feb 18, 2021

Uh oh!

izaera commented Feb 18, 2021

Uh oh!

wincent left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jbalsas commented Feb 19, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

izaera commented Feb 19, 2021

Uh oh!

izaera commented Feb 19, 2021

Uh oh!

jbalsas commented Feb 19, 2021

Uh oh!

jbalsas commented Feb 19, 2021

Uh oh!

izaera commented Feb 22, 2021

Uh oh!

izaera commented Feb 22, 2021

Uh oh!

calvinctvo commented Feb 23, 2021

Uh oh!

liferay-continuous-integration commented Feb 24, 2021

✔️ ci:test:stable - 9 out of 9 jobs passed

❌ ci:test:relevant - 21 out of 33 jobs passed in 3 hours 45 minutes

Base Branch:

Upstream Comparison:

12 Failed Jobs:

For more details click here.

Failures unique to this pull:

Job Results:

Job Results:

Job Results:

Job Results:

Job Results:

Uh oh!

liferay-continuous-integration commented Feb 24, 2021

Uh oh!

izaera commented Feb 24, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

izaera commented Feb 24, 2021

Uh oh!

izaera commented Feb 24, 2021

Uh oh!

izaera commented Feb 24, 2021

Uh oh!

liferay-continuous-integration commented Feb 24, 2021

✔️ ci:test:sf - 1 out of 1 jobs passed in 6 minutes

Base Branch:

Sender Branch:

For more details click here.

Uh oh!

liferay-continuous-integration commented Feb 24, 2021

Uh oh!

liferay-continuous-integration commented Feb 24, 2021

✔️ ci:test:stable - 9 out of 9 jobs passed

❌ ci:test:relevant - 21 out of 33 jobs passed in 7 hours 6 minutes

Base Branch:

Upstream Comparison:

12 Failed Jobs:

For more details click here.

Failures unique to this pull:

Job Results:

Job Results:

Job Results:

Job Results:

Job Results:

Uh oh!

izaera commented Feb 18, 2021 •

edited

Loading

jbalsas commented Feb 19, 2021 •

edited

Loading

izaera commented Feb 24, 2021 •

edited

Loading